-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use happychat-client npm package #23630
Conversation
// This is needed because babel doesn't play well with symlinks, this allows node_modules to | ||
// work as symlinks (`npm link`) needed when developing one of the dependencies. | ||
// Reference https://github.com/babel/babel-loader/issues/149 | ||
symlinks: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should measure how this change impacts the Webpack compile times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look into that when there will be a proper HC-Calypso integration in place. This is more of an experiment to test the authentication. However I don't think it would impact compile times as it will affect only npm link
ed packages' path.
This branch needs a rebase. Is this PR still required? |
Sorry for the late response, I was afk, the Happychat Client Calypso integration was put on hold as our team has other high priority work scheduled. We will most likely come back to this after the GM. So let's keep the PRs around. Thanks |
Closing due to inactivity. Please reopen if necessary. |
Summary
This is an experiment to add happychat-client as a npm package to calypso.