Use happychat-client npm package #23630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2018
lamosty
reviewed
Mar 28, 2018
| // This is needed because babel doesn't play well with symlinks, this allows node_modules to | ||
| // work as symlinks (`npm link`) needed when developing one of the dependencies. | ||
| // Reference https://github.com/babel/babel-loader/issues/149 | ||
| symlinks: false, |
There was a problem hiding this comment.
We should measure how this change impacts the Webpack compile times.
There was a problem hiding this comment.
Will look into that when there will be a proper HC-Calypso integration in place. This is more of an experiment to test the authentication. However I don't think it would impact compile times as it will affect only npm linked packages' path.
|
This branch needs a rebase. Is this PR still required? |
|
Sorry for the late response, I was afk, the Happychat Client Calypso integration was put on hold as our team has other high priority work scheduled. We will most likely come back to this after the GM. So let's keep the PRs around. Thanks |
|
Closing due to inactivity. Please reopen if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an experiment to add happychat-client as a npm package to calypso.